Benjamin Otte [Tue, 24 Oct 2017 16:13:45 +0000 (18:13 +0200)]
Add default return values to switch statements
We are using g_assert_not_reached() without doing anything, assuming it
aborts the program. In release builds however, it is ignored.
Emmanuele Bassi [Tue, 24 Oct 2017 15:58:06 +0000 (16:58 +0100)]
Add a return value
When building with G_DISABLE_ASSERT, the g_assert_not_reached()
statement won't do anything, and we're going to fall through, and the
compiler will emit a warning that we're not returning anything from a
function with a return value.
Matthias Clasen [Tue, 24 Oct 2017 13:20:00 +0000 (15:20 +0200)]
inspector: Show more render node details
Should clip and container node details.
Chun-wei Fan [Tue, 24 Oct 2017 05:55:36 +0000 (13:55 +0800)]
gdk/win32/gdkwindow-win32.c: Fix build
Make up for the missed commas...
Benjamin Otte [Mon, 23 Oct 2017 23:28:46 +0000 (01:28 +0200)]
vulkan: No need to redefine gl_PerVertex
The compiler has those predefined, so use them.
Benjamin Otte [Mon, 23 Oct 2017 23:20:50 +0000 (01:20 +0200)]
vulkan: Delete unused shaders
These have been renamed to .frag/.vert, apparently the originals weren't
deleted.
Matthias Clasen [Mon, 23 Oct 2017 16:33:15 +0000 (18:33 +0200)]
Mention pixbufs in the migration guide
They are being phased out.
Alexander Larsson [Mon, 23 Oct 2017 14:39:44 +0000 (16:39 +0200)]
Drop all uses of GdkPixbufAnimation in the gtk APIs
These are basically animated gifs, and don't fit well in how
modern things animate.
Benjamin Otte [Mon, 23 Oct 2017 14:28:38 +0000 (16:28 +0200)]
build: Warn about ignored qualifiers
https://bugzilla.gnome.org/show_bug.cgi?id=789351
Emmanuele Bassi [Mon, 23 Oct 2017 14:23:09 +0000 (15:23 +0100)]
Remove unnecessary const
We return a scalar value, so we don't need it to be constant.
https://bugzilla.gnome.org/show_bug.cgi?id=789351
Alexander Larsson [Mon, 23 Oct 2017 13:34:17 +0000 (15:34 +0200)]
GtkIconHelper: Remove unused code
Alexander Larsson [Mon, 23 Oct 2017 13:25:46 +0000 (15:25 +0200)]
Drop pixbuf support in IconHelper and ImageDefinition
These are no longer used, instead we always covert to surface as
early as possible and drop the pixbuf.
This means we never store both the pixbuf and the surface at
for any longer time, which is wasteful. Also, its one step further
to drop GdkPixbufs from generic use in our APIs.
Alexander Larsson [Mon, 23 Oct 2017 13:15:35 +0000 (15:15 +0200)]
GtkDragSource: Don't use gtk_image_definition_new_pixbuf
We want to get rid of pixbuf image definitions.
Long term this should probably be gtk_drag_source_set_icon_surface instead.
Alexander Larsson [Mon, 23 Oct 2017 13:03:31 +0000 (15:03 +0200)]
CellRendererPixbuf: Never store pixbufs
Rather than store the pixbufs as themselves we immediately convert
them to surfaces. In the uncommon case that a pixbuf is read back
from the renderer we generate a new one from the surface data.
Alexander Larsson [Mon, 23 Oct 2017 12:47:50 +0000 (14:47 +0200)]
GtkImage: Drop support for storing pixbufs
This drops the pixbuf property and the pixbuf getters. We keep
gtk_image_new/set_from_pixbuf, but these are small helpers that
immediately convert to a surface, and there is no way to later get
back the pixbuf you passed in.
The from file/resource codepaths are also changed to load a surface
instead of a pixbuf.
Timm Bäder [Mon, 23 Oct 2017 12:43:47 +0000 (14:43 +0200)]
window: Use correct destroy notify for icon list
The list contains cairo_surface_t instances now, not GdkPixbuf anymore.
Timm Bäder [Mon, 23 Oct 2017 11:39:22 +0000 (13:39 +0200)]
icontheme: Silence some compiler warnings
Matthias Clasen [Mon, 23 Oct 2017 12:16:31 +0000 (14:16 +0200)]
dnd: Add more surface apis
The new function, gtk_drag_source_set_icon_surface, is for setting
a drag source icon without using GdkPixbuf.
Alexander Larsson [Mon, 23 Oct 2017 11:43:50 +0000 (13:43 +0200)]
GtkWindow/GdkWindow: Finish converting icons to surfaces
There were some parts left, for instance gdk_window_set_icon_list.
Alexander Larsson [Mon, 23 Oct 2017 10:49:42 +0000 (12:49 +0200)]
GtkEntry: Use surfaces, not pixbufs for bitmapped icons
Alexander Larsson [Mon, 23 Oct 2017 10:48:11 +0000 (12:48 +0200)]
aboutdialog: Use set_boxed on surface
cairo_surface_t is boxed, not a GObject.
Matthias Clasen [Mon, 23 Oct 2017 09:24:49 +0000 (11:24 +0200)]
inspector: show color matrix node details
Show the matrix and the offset for color matrix nodes.
Matthias Clasen [Mon, 23 Oct 2017 07:08:25 +0000 (09:08 +0200)]
Use a color matrix for symbolic icons
The recoloring of symbolic icons is just a color matrix
operation.
Matthias Clasen [Mon, 23 Oct 2017 09:42:23 +0000 (11:42 +0200)]
Allow passing a color matrix when rendering icons
This will be used for symbolic icons.
Update all callers.
Matthias Clasen [Mon, 23 Oct 2017 05:53:09 +0000 (07:53 +0200)]
icon helper: Use cached textures
Use a cached texture for themed icons if we can.
Currently, we only do this for non-symbolic icons.
Matthias Clasen [Mon, 23 Oct 2017 05:51:45 +0000 (07:51 +0200)]
icon theme: Add a texture cache
Return cached textures for icons. This lets us avoid duplicate
texture uploads for icons whose surfaces we already cache.
Matthias Clasen [Mon, 23 Oct 2017 06:04:46 +0000 (08:04 +0200)]
recent manager: Remove dead code
These functions are no longer used.
Timm Bäder [Sun, 22 Oct 2017 14:58:53 +0000 (16:58 +0200)]
testsuite: Disable vulkan tests when vulkan isn't available
They are always going to fail in that case anyway.
Timm Bäder [Sun, 22 Oct 2017 13:26:16 +0000 (15:26 +0200)]
adwaita: Remove focus outlines from textviews
Matthias Clasen [Mon, 23 Oct 2017 05:39:12 +0000 (07:39 +0200)]
window: Correct the property definition for icon
cairo surfaces are boxed types, not objects.
Matthias Clasen [Mon, 23 Oct 2017 05:38:36 +0000 (07:38 +0200)]
about dialog: Correct the property definition for logo
cairo surfaces are boxed types, not objects.
Matthias Clasen [Mon, 23 Oct 2017 04:21:34 +0000 (06:21 +0200)]
Drop gtk_drag_set_icon_pixbuf from the docs too
It no longer exists.
Matthias Clasen [Mon, 23 Oct 2017 04:20:08 +0000 (06:20 +0200)]
Drop gtk_recent_info_get_icon
We are moving away from pixbuf-based apis.
Use gtk_recent_info_get_gicon instead.
Matthias Clasen [Mon, 23 Oct 2017 03:59:30 +0000 (05:59 +0200)]
Add gtk_image_get_surface to the docs
This was missed.
Matthias Clasen [Mon, 23 Oct 2017 03:53:23 +0000 (05:53 +0200)]
Document new clipboard apis
These are surface-based replacements for some pixbuf apis.
Matthias Clasen [Mon, 23 Oct 2017 03:46:58 +0000 (05:46 +0200)]
Document new selection apis
Document the new cairo surface-based apis for GtkSelection.
Matthias Clasen [Mon, 23 Oct 2017 03:43:05 +0000 (05:43 +0200)]
Drop gtk_drag_set_icon_pixbuf
We are moving away from GdkPixbuf in the api.
Use surface-based replacements instead.
Matthias Clasen [Mon, 23 Oct 2017 03:42:24 +0000 (05:42 +0200)]
Use surface apis in testnotebookdnd
Stop using gtk_drag_set_icon_pixbuf.
This api is going away.
Matthias Clasen [Mon, 23 Oct 2017 03:41:29 +0000 (05:41 +0200)]
tests: Use surface apis in testimage
Stop using gtk_drag_set_icon_pixbuf.
This api is going away.
Matthias Clasen [Mon, 23 Oct 2017 03:40:20 +0000 (05:40 +0200)]
gtk-demo: Use surface apis in the clipboard demo
Stop using gtk_drag_set_icon_pixbuf.
This api is going away.
Matthias Clasen [Mon, 23 Oct 2017 03:27:01 +0000 (05:27 +0200)]
tests: Convert dnd test to surface apis
Stop using gtk_drag_set_icon_pixbuf in testdnd2.
This api is going away.
Matthias Clasen [Mon, 23 Oct 2017 03:22:28 +0000 (05:22 +0200)]
selection: Add another surface api
Of course, we need a getter too.
Alexander Larsson [Sun, 22 Oct 2017 21:03:19 +0000 (23:03 +0200)]
GtkAboutDialog: Use surfaces for logo
Alexander Larsson [Sun, 22 Oct 2017 20:57:55 +0000 (22:57 +0200)]
gtk_image_get_surface: Add docs
Alexander Larsson [Sun, 22 Oct 2017 20:57:21 +0000 (22:57 +0200)]
GtkWindow: Use cairo_surface_t for icons
Matthias Clasen [Sun, 22 Oct 2017 20:21:21 +0000 (22:21 +0200)]
recent chooser: Don't use pixbuf based apis
Use gtk_drag_set_icon_surface here.
Matthias Clasen [Sun, 22 Oct 2017 20:20:12 +0000 (22:20 +0200)]
recent manager: always return a GIcon
Make gtk_recent_info_get_gicon return a useful GIcon in
all cases.
Matthias Clasen [Sun, 22 Oct 2017 20:19:31 +0000 (22:19 +0200)]
selection: Add surface based apis
Add gtk_selection_data_set_surface.
Matthias Clasen [Sun, 22 Oct 2017 20:18:32 +0000 (22:18 +0200)]
image: Add surface based apis
Add gtk_image_get_surface.
Matthias Clasen [Sun, 22 Oct 2017 20:17:43 +0000 (22:17 +0200)]
clipboard: Add surface apis
Add gtk_clipboard_set_surface and gtk_clipboard_wait_for_surface.
Matthias Clasen [Sat, 21 Oct 2017 13:17:36 +0000 (15:17 +0200)]
Fix compiler warnings
I overlooked these when I recently did the render node api changes.
Timm Bäder [Fri, 20 Oct 2017 13:12:28 +0000 (15:12 +0200)]
overlay: Remove unused NULL-check
Timm Bäder [Fri, 20 Oct 2017 08:58:31 +0000 (10:58 +0200)]
window: Make sure we query the window size before size-allocate'ing
Timm Bäder [Thu, 19 Oct 2017 14:58:19 +0000 (16:58 +0200)]
gdkevents: Remove gtk_widget_set_events mention
Doesn't exist anymore.
Timm Bäder [Thu, 19 Oct 2017 13:41:20 +0000 (15:41 +0200)]
renderborder: Don't snapshot all-invisible borders
If all of the borders have an alpha of 0, we don't need to snapshot
anything.
Timm Bäder [Thu, 19 Oct 2017 13:22:00 +0000 (15:22 +0200)]
renderbackground: Minimize style lookups
Move the early returns up so we don't look up all those css values for
no reason.
Timm Bäder [Wed, 18 Oct 2017 08:39:44 +0000 (10:39 +0200)]
widget: Remove outdated comment on get_allocation
The allocation passed to gtk_widget_size_allocate can be retrieved these
days, using gtk_widget_get_allocated_size.
Matthias Clasen [Fri, 20 Oct 2017 12:43:11 +0000 (14:43 +0200)]
window: Remove dead code
GtkWindow never has a parent widget, so we never need to create
a child window for it.
Matthias Clasen [Fri, 20 Oct 2017 09:21:05 +0000 (11:21 +0200)]
Remove some outdated information
Render nodes don't have transformations, currently.
Only transform nodes do.
Matthias Clasen [Fri, 20 Oct 2017 07:11:48 +0000 (09:11 +0200)]
docs: Add render node api
Matthias Clasen [Fri, 20 Oct 2017 07:31:14 +0000 (09:31 +0200)]
Tweak transform node apis
Rename the getter to follow the peek naming scheme.
Update all callers.
Matthias Clasen [Fri, 20 Oct 2017 07:12:19 +0000 (09:12 +0200)]
gsk: Tweak text node apis
Rename getters to follow the peek naming pattern.
Update all callers.
Matthias Clasen [Fri, 20 Oct 2017 06:52:02 +0000 (08:52 +0200)]
gsk: Tweak cairo node apis
Rename the surface getter to peek, following other render
node getters, and make the surface-based constructor private,
since it is not something we want to encourage.
Update all callers.
Matthias Clasen [Fri, 20 Oct 2017 06:06:20 +0000 (08:06 +0200)]
Make render node getter public
Keeping these private does not really buy us anything.
Matthias Clasen [Fri, 20 Oct 2017 06:05:46 +0000 (08:05 +0200)]
Bump version to 3.93
This lets us add new API without deprecation warnings.
Emmanuele Bassi [Fri, 20 Oct 2017 10:22:45 +0000 (11:22 +0100)]
build: Fix gtk_tools array expansion
The gtk_tools variable is an array of arrays; adding a new element
requires to maintain the same type, or we'll get a build failure when
we try to extract the newly added element.
Chun-wei Fan [Tue, 1 Aug 2017 08:49:08 +0000 (16:49 +0800)]
Meson: Support Windows builds
Add the necessary machinery into the Meson definition files so that we
can build for Windows.
Since we don't have Wayland or X support for our use case here, disable
them once we know that we are building for Windows, as they are
(otherwise) enabled by default, and enable the items that need to be
built for Windows builds.
Exclude gtk4-launch from Windows builds as that is something that
is not supported on Windows.
As we won't have gio-unix on Windows, and PangoFT2 is optional, don't use
fallbacks for them when we are on Windows (but do use fallbacks for
gio-win32, as it will be used).
Also, clean up meson.build a bit as we can just force-include
msvc_recommended_pragmas.h from GLib since we depend on GLib, and so we
can handle these warnings from msvc_recommended_pragmas.h instead.
https://bugzilla.gnome.org/show_bug.cgi?id=785210
Michael Catanzaro [Fri, 20 Oct 2017 00:52:11 +0000 (19:52 -0500)]
Revert "gdk/wayland: Avoid idempotent wl_subsurface.set_position calls"
This reverts commit
1607f8c4c64b95329f0c02fde7070c35b2bfb2ad.
https://bugzilla.gnome.org/show_bug.cgi?id=784314
Carlos Garnacho [Thu, 19 Oct 2017 14:13:47 +0000 (16:13 +0200)]
icon-browser: Remove GtkEventBox from .ui file
The patch adding scalable icons' info was forward ported too much as-is
to master. The event box is both unused and unnecessary here.
Matthias Clasen [Thu, 19 Oct 2017 13:15:13 +0000 (15:15 +0200)]
Avoid super-luminous pixels
The color-matrix shader was creating pixels with r,g,b > a in
some cases, which leads to unexpected test failures. In particular
this as visible the opacity render node test for opacity 0.
Marc-Antoine Perennou [Thu, 19 Oct 2017 12:22:23 +0000 (14:22 +0200)]
gdk: add accessor for GdkEventOwnerChange::reason
https://bugzilla.gnome.org/show_bug.cgi?id=789198
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Matthias Clasen [Thu, 19 Oct 2017 10:18:12 +0000 (12:18 +0200)]
Add 3.94 version macros
Matthias Clasen [Thu, 19 Oct 2017 10:01:02 +0000 (12:01 +0200)]
Optimize away trivial opacities
No need to go color matrix on an opacity of 0 or 1.
Debarshi Ray [Wed, 18 Oct 2017 14:44:33 +0000 (16:44 +0200)]
GtkGestureZoom: Don't leak the list of sequences
https://bugzilla.gnome.org/show_bug.cgi?id=789149
Matthias Clasen [Tue, 17 Oct 2017 17:22:27 +0000 (01:22 +0800)]
Add a test for opacity render nodes
This test currently fails with the Vulkan renderer, despite
having its own reference image.
Matthias Clasen [Wed, 18 Oct 2017 21:11:07 +0000 (23:11 +0200)]
3.92.1
Change the project name back to gtk+ to avoid trouble with
tarball names not matching ftpadmin expectations.
Matthias Clasen [Wed, 18 Oct 2017 16:29:53 +0000 (18:29 +0200)]
3.92.0
Matthias Clasen [Wed, 18 Oct 2017 16:46:12 +0000 (18:46 +0200)]
Fix tools test
Matthias Clasen [Wed, 18 Oct 2017 16:35:34 +0000 (18:35 +0200)]
Add a forgotten file
Piotr Drąg [Wed, 18 Oct 2017 15:54:07 +0000 (17:54 +0200)]
Update POTFILES.skip
Matthias Clasen [Wed, 18 Oct 2017 14:45:52 +0000 (16:45 +0200)]
Use the cairo renderer for gtk tests for now
We haven't tracked down yet why the window size tests
fail with Vulkan, so use cairo for now.
Matthias Clasen [Wed, 18 Oct 2017 08:55:02 +0000 (16:55 +0800)]
Fix test environments
Matthias Clasen [Wed, 18 Oct 2017 02:41:57 +0000 (10:41 +0800)]
Install tools tests
At the same time, update the expected test output to match
the current tools output, and write diff and ref files in /tmp.
Matthias Clasen [Wed, 18 Oct 2017 02:18:51 +0000 (10:18 +0800)]
Install gtk tests
Some of these currently fail on my system.
Matthias Clasen [Wed, 18 Oct 2017 01:52:48 +0000 (09:52 +0800)]
redo the gdk installed tests
Matthias Clasen [Wed, 18 Oct 2017 01:48:34 +0000 (09:48 +0800)]
testsuite: be a bit more verbose
This may help tracking down some failures.
Matthias Clasen [Wed, 18 Oct 2017 01:40:53 +0000 (09:40 +0800)]
Install separate render node test for cairo and vulkan
The vulkan test currently fails.
Matthias Clasen [Wed, 18 Oct 2017 01:33:59 +0000 (09:33 +0800)]
testsuite: don't write into installed locations
Save the output of the render node tests in /tmp.
Matthias Clasen [Wed, 18 Oct 2017 01:19:44 +0000 (09:19 +0800)]
Install gdk tests
This was missing so far
Matthias Clasen [Wed, 18 Oct 2017 00:48:16 +0000 (08:48 +0800)]
Test suite cosmetics
Reshuffle things a bit more, sort the test files into subdirectories,
and shorten their names.
Matthias Clasen [Tue, 17 Oct 2017 18:56:41 +0000 (02:56 +0800)]
Add some backend-specific reference images for render nodes
Matthias Clasen [Tue, 17 Oct 2017 18:50:49 +0000 (02:50 +0800)]
Run the gsk tests for both cairo and vulkan
The vulkan tests fail currently.
Matthias Clasen [Tue, 17 Oct 2017 18:50:05 +0000 (02:50 +0800)]
More testsuite cosmetics
Unify the test naming some more.
Matthias Clasen [Wed, 18 Oct 2017 08:55:20 +0000 (16:55 +0800)]
Fix the a11y test
Matthias Clasen [Wed, 18 Oct 2017 15:20:53 +0000 (17:20 +0200)]
Update expected output of statusbar a11y test
Matthias Clasen [Wed, 18 Oct 2017 15:20:14 +0000 (17:20 +0200)]
Fix GtkStatusbarAccessible
GtkStatusbar is no longer a container, so GtkStatusbarAccessible
can no longer be a container accessible.
Matthias Clasen [Wed, 18 Oct 2017 00:53:07 +0000 (08:53 +0800)]
gtk4-demo: Stop using pixdata resources
This does not really help, and pixdata is deprecated.
Matthias Clasen [Wed, 18 Oct 2017 00:53:49 +0000 (08:53 +0800)]
gtk: Stop using pixdata resources
It does not really help, and pixdata is deprecated.
Matthias Clasen [Tue, 17 Oct 2017 09:54:02 +0000 (17:54 +0800)]
testsuite: Add missing files
Matthias Clasen [Tue, 17 Oct 2017 09:35:28 +0000 (17:35 +0800)]
testsuite: Use the cairo renderer for now